Open
Conversation
4 tasks
wojiaodoubao
force-pushed
the
rest-table-properties
branch
from
f6bb488 to
a122997
Compare
github-actions
bot
added
python
Collaborator
Author
|
Hi @jackye1995 , could you help review this pr, what do you think? This is a prerequisite for lance-format/lance#5738. After this we can move on PartitionedNamespace. |
jackye1995
reviewed
Feb 6, 2026
| Optional table metadata as key-value pairs. | ||
| additionalProperties: | ||
| type: string | ||
| properties: |
Collaborator
There was a problem hiding this comment.
lol I removed this because lance tables have metadata, I guess we will have to add this back.
I think we should describe clearly when to expect metadata, when to expect properties. metadata requires loading the table, i.e. load_detailed_metadata=true, whereas properties record information of the table that is outside the table, typically managed by the namespace, for example owner.
Collaborator
Author
There was a problem hiding this comment.
Thanks~ Fixed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a sub-task of the partitioned namespace, designed to introduce table properties in namespace rest spec. Partition Namespace will set partition fields through
create table,create empty table,register tablewith extended table properties, which are stored in __manifest partition field columns.